Feat: charging broker fee per chunk and in USDC #5161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5161 +/- ##
======================================
- Coverage 70% 70% -0%
======================================
Files 481 481
Lines 85760 85829 +69
Branches 85760 85829 +69
======================================
- Hits 60207 60106 -101
- Misses 22286 22452 +166
- Partials 3267 3271 +4 ☔ View full report in Codecov by Sentry. |
j4m1ef0rd
reviewed
Aug 19, 2024
msgmaxim
force-pushed
the
feat/broker-fee-per-chunk
branch
from
c5649e3
to
86aa05a
Compare
j4m1ef0rd
reviewed
Aug 20, 2024
dandanlen
reviewed
Aug 21, 2024
dandanlen
approved these changes
Aug 22, 2024
dandanlen
force-pushed
the
feat/broker-fee-per-chunk
branch
from
76f7343
to
2e7b827
Compare
dandanlen
force-pushed
the
feat/broker-fee-per-chunk
branch
from
f5d07b7
to
927c8ae
Compare
syan095
added a commit
that referenced
this pull request
Aug 22, 2024
…ovide-shared-data * origin/main: feature: Added benchmark for delete vote (#5189) Feat: charging broker fee per chunk and in USDC (#5161) Feat: solana deployments (#5188) chore: bouncer add check for solana nonces (#5185) # Conflicts: # state-chain/pallets/cf-elections/src/benchmarking.rs # state-chain/pallets/cf-elections/src/weights.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Closes: PRO-1540 and PRO-1483
Checklist
Please conduct a thorough self-review before opening the PR.
Summary
The PR is indended to be reviewed by individual commits
broker_feefield fromSwapRequestedtoSwapExecuted(FYI @zoheb391 and @acdibble). Don't think there are any other implications for the product, other than brokers noticing that only their USDC balance is changing.swap_broker_fee_subtracted_from_swap_amountwas mostly a duplicate so I merged it withexpect_earned_fees_to_be_recorded.CcmandRegularvariants from SwapRequestState intoUserSwap. Didn't really result in code deduplication, but at least we no longer repeat swap parameters (like the newly added broker_fees).Edit: Updated broker fee tests in bouncer. Because all fees are charged in USDC I ended up leaving only a test for one asset (as opposed to all assets). Keeping all assets seems no longer necessary, and wouldn't be trivial (would likely require running the tests sequentially or with multiple broker account).