From 10a814c3054b87a16470eb3cf3fa964e49b39efd Mon Sep 17 00:00:00 2001
From: Daniel <daniel@chainflip.io>
Date: Thu, 21 Mar 2024 08:57:52 +0100
Subject: [PATCH] fix: remove cfe events migration

It's not needed since cfe events are always deleted at the start of a block.
---
 .../pallets/cf-cfe-interface/src/lib.rs       |  2 +-
 .../cf-cfe-interface/src/migrations.rs        |  6 +-
 .../src/migrations/add_arb_to_cfe_events.rs   | 76 -------------------
 3 files changed, 3 insertions(+), 81 deletions(-)
 delete mode 100644 state-chain/pallets/cf-cfe-interface/src/migrations/add_arb_to_cfe_events.rs

diff --git a/state-chain/pallets/cf-cfe-interface/src/lib.rs b/state-chain/pallets/cf-cfe-interface/src/lib.rs
index 53f3f63657..0d8fc49fc2 100644
--- a/state-chain/pallets/cf-cfe-interface/src/lib.rs
+++ b/state-chain/pallets/cf-cfe-interface/src/lib.rs
@@ -21,7 +21,7 @@ use frame_system::pallet_prelude::*;
 pub use pallet::*;
 use sp_std::vec::Vec;
 
-pub const PALLET_VERSION: StorageVersion = StorageVersion::new(1);
+pub const PALLET_VERSION: StorageVersion = StorageVersion::new(0);
 
 pub type EventId = u64;
 
diff --git a/state-chain/pallets/cf-cfe-interface/src/migrations.rs b/state-chain/pallets/cf-cfe-interface/src/migrations.rs
index 0a28096190..9667705e72 100644
--- a/state-chain/pallets/cf-cfe-interface/src/migrations.rs
+++ b/state-chain/pallets/cf-cfe-interface/src/migrations.rs
@@ -1,6 +1,4 @@
-pub mod add_arb_to_cfe_events;
-
-use cf_runtime_upgrade_utilities::VersionedMigration;
+use cf_runtime_upgrade_utilities::{migration_template, VersionedMigration};
 
 pub type PalletMigration<T> =
-	(VersionedMigration<crate::Pallet<T>, add_arb_to_cfe_events::Migration<T>, 0, 1>,);
+	(VersionedMigration<crate::Pallet<T>, migration_template::Migration<T>, 0, 1>,);
diff --git a/state-chain/pallets/cf-cfe-interface/src/migrations/add_arb_to_cfe_events.rs b/state-chain/pallets/cf-cfe-interface/src/migrations/add_arb_to_cfe_events.rs
deleted file mode 100644
index 9db34e5df0..0000000000
--- a/state-chain/pallets/cf-cfe-interface/src/migrations/add_arb_to_cfe_events.rs
+++ /dev/null
@@ -1,76 +0,0 @@
-use crate::*;
-use core::marker::PhantomData;
-use frame_support::{pallet_prelude::*, traits::OnRuntimeUpgrade};
-use sp_std::vec;
-
-pub struct Migration<T: Config>(PhantomData<T>);
-
-mod old {
-	use super::*;
-	use cfe_events::{
-		KeyHandoverRequest, KeygenRequest, ThresholdSignatureRequest, TxBroadcastRequest,
-	};
-
-	#[derive(Clone, RuntimeDebug, Encode, Decode, PartialEq, Eq, TypeInfo)]
-	pub enum CfeEvent<ValidatorId> {
-		EthThresholdSignatureRequest(ThresholdSignatureRequest<ValidatorId, EvmCrypto>),
-		DotThresholdSignatureRequest(ThresholdSignatureRequest<ValidatorId, PolkadotCrypto>),
-		BtcThresholdSignatureRequest(ThresholdSignatureRequest<ValidatorId, BitcoinCrypto>),
-		EthKeygenRequest(KeygenRequest<ValidatorId>),
-		DotKeygenRequest(KeygenRequest<ValidatorId>),
-		BtcKeygenRequest(KeygenRequest<ValidatorId>),
-		BtcKeyHandoverRequest(KeyHandoverRequest<ValidatorId, BitcoinCrypto>),
-		EthTxBroadcastRequest(TxBroadcastRequest<ValidatorId, Ethereum>),
-		DotTxBroadcastRequest(TxBroadcastRequest<ValidatorId, Polkadot>),
-		BtcTxBroadcastRequest(TxBroadcastRequest<ValidatorId, Bitcoin>),
-		PeerIdRegistered {
-			account_id: ValidatorId,
-			pubkey: Ed25519PublicKey,
-			port: Port,
-			ip: Ipv6Addr,
-		},
-		PeerIdDeregistered {
-			account_id: ValidatorId,
-			pubkey: Ed25519PublicKey,
-		},
-	}
-}
-
-impl<T: Config> OnRuntimeUpgrade for Migration<T> {
-	fn on_runtime_upgrade() -> frame_support::weights::Weight {
-		CfeEvents::<T>::translate(|old_cfe_events| {
-			let mut new_cfe_events: Vec<CfeEvent<T>> = vec![];
-			old_cfe_events.into_iter().for_each(|old_cfe_event| new_cfe_events.push(match old_cfe_event {
-                    old::CfeEvent::<<T as Chainflip>::ValidatorId>::EthThresholdSignatureRequest(sig_request) => CfeEvent::<T>::EvmThresholdSignatureRequest(sig_request),
-                    old::CfeEvent::<<T as Chainflip>::ValidatorId>::DotThresholdSignatureRequest(sig_request) => CfeEvent::<T>::DotThresholdSignatureRequest(sig_request),
-                    old::CfeEvent::<<T as Chainflip>::ValidatorId>::BtcThresholdSignatureRequest(sig_request) => CfeEvent::<T>::BtcThresholdSignatureRequest(sig_request),
-                    old::CfeEvent::<<T as Chainflip>::ValidatorId>::EthKeygenRequest(keygen_request) => CfeEvent::<T>::EvmKeygenRequest(keygen_request),
-                    old::CfeEvent::<<T as Chainflip>::ValidatorId>::DotKeygenRequest(keygen_request) => CfeEvent::<T>::DotKeygenRequest(keygen_request),
-                    old::CfeEvent::<<T as Chainflip>::ValidatorId>::BtcKeygenRequest(keygen_request) => CfeEvent::<T>::BtcKeygenRequest(keygen_request),
-                    old::CfeEvent::<<T as Chainflip>::ValidatorId>::BtcKeyHandoverRequest(handover_request) => CfeEvent::<T>::BtcKeyHandoverRequest(handover_request),
-                    old::CfeEvent::<<T as Chainflip>::ValidatorId>::EthTxBroadcastRequest(broadcast_request) => CfeEvent::<T>::EthTxBroadcastRequest(broadcast_request),
-                    old::CfeEvent::<<T as Chainflip>::ValidatorId>::DotTxBroadcastRequest(broadcast_request) => CfeEvent::<T>::DotTxBroadcastRequest(broadcast_request),
-                    old::CfeEvent::<<T as Chainflip>::ValidatorId>::BtcTxBroadcastRequest(broadcast_request) => CfeEvent::<T>::BtcTxBroadcastRequest(broadcast_request),
-                    old::CfeEvent::<<T as Chainflip>::ValidatorId>::PeerIdRegistered {
-                        account_id,
-                        pubkey,
-                        port,
-                        ip,
-                    } => CfeEvent::<T>::PeerIdRegistered { account_id, pubkey, port, ip },
-                    old::CfeEvent::<<T as Chainflip>::ValidatorId>::PeerIdDeregistered { account_id, pubkey } => CfeEvent::<T>::PeerIdDeregistered{account_id, pubkey},
-                }));
-			Some(new_cfe_events)
-		}).expect("vvv");
-		Weight::zero()
-	}
-
-	#[cfg(feature = "try-runtime")]
-	fn pre_upgrade() -> Result<Vec<u8>, DispatchError> {
-		Ok(vec![])
-	}
-
-	#[cfg(feature = "try-runtime")]
-	fn post_upgrade(_state: Vec<u8>) -> Result<(), DispatchError> {
-		Ok(())
-	}
-}