Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

old attestations are not showing up policy evaluations in WorkflowRun endpoints #1755

Closed
jiparis opened this issue Jan 24, 2025 · 1 comment · Fixed by #1756
Closed

old attestations are not showing up policy evaluations in WorkflowRun endpoints #1755

jiparis opened this issue Jan 24, 2025 · 1 comment · Fixed by #1756
Assignees
@jiparis
Labels
bug Something isn't working

Comments

@jiparis
Copy link
Member

jiparis commented Jan 24, 2025

Since all fields are now camel-cased (https://github.com/chainloop-dev/chainloop/pull/1739/files), old attestations cannot be parsed completely.
In particular policy_evaluations fields are lost during the unmarshall process, we might need to add a fallback field.
@jiparis jiparis added the bug Something isn't working label Jan 24, 2025
@jiparis jiparis mentioned this issue Jan 24, 2025
Merged
@jiparis
Copy link
Member Author

jiparis commented Jan 24, 2025

materialName and policyReference fields inside PolicyEvaluation struct are also affected

@jiparis jiparis self-assigned this Jan 24, 2025
@javirln javirln reopened this Jan 24, 2025
@jiparis jiparis mentioned this issue Jan 24, 2025
Merged
@javirln javirln closed this as completed Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiparis jiparis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(attestations): add compatibility with old policy evaluations jiparis/chainloop
2 participants
@jiparis @javirln