Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] upstream url unsupport underline '_' #985

Closed
Sndav opened this issue Jul 11, 2024 · 5 comments
Closed

[Bug] upstream url unsupport underline '_' #985

Sndav opened this issue Jul 11, 2024 · 5 comments
Labels
enhancement New feature or request released

Comments

@Sndav
Copy link

Sndav commented Jul 11, 2024

What happened?

upstream域名无法添加下划线

How we reproduce?

如图
image

Expected behavior

校验通过

Error log

No response

@Lorna0 Lorna0 changed the title [Bug] upstream域名无法添加下划线 [Bug] upstream 无法添加下划线 Jul 12, 2024
@Lorna0 Lorna0 added the enhancement New feature or request label Jul 12, 2024
@Lorna0
Copy link
Collaborator

Lorna0 commented Jul 12, 2024

根据 https://cabforum.org/2018/11/12/ballot-sc12-sunset-of-underscores-in-dnsnames/ ,域名里不建议使用下划线。

如果当作 hostname 的话可以考虑。

@Sndav
Copy link
Author

Sndav commented Jul 15, 2024

image

不过还是建议增加一下这个功能

@Lorna0
Copy link
Collaborator

Lorna0 commented Jul 15, 2024

您这个https://cabforum.org/2018/11/12/ballot-sc12-sunset-of-underscores-in-dnsnames/指的是TLS证书中的域名字段,不是dns解析的NAME

没错,我的意思就是指 TLS 证书中的域名字段不建议使用下划线,所以不建议域名使用下划线。因为域名一般都需要证书,否则容易有安全问题。

域名中增加下划线确实是存在一定争议的,协议中允许,但是实际运用中可能存在一些问题。

不过考虑到 upstream 不一定是域名,也可能是 hostname,hostname 的要求就宽松多了,我们有空会改成允许下划线。

@safe1ine safe1ine changed the title [Bug] upstream 无法添加下划线 [Bug] upstream url unsupport underline '_' Jul 15, 2024
@Lorna0
Copy link
Collaborator

Lorna0 commented Jul 30, 2024

Released in 6.2.3

@xbingW xbingW closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

No branches or pull requests

3 participants