-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] upstream url unsupport underline '_' #985
Labels
Comments
根据 https://cabforum.org/2018/11/12/ballot-sc12-sunset-of-underscores-in-dnsnames/ ,域名里不建议使用下划线。 如果当作 hostname 的话可以考虑。 |
没错,我的意思就是指 TLS 证书中的域名字段不建议使用下划线,所以不建议域名使用下划线。因为域名一般都需要证书,否则容易有安全问题。 域名中增加下划线确实是存在一定争议的,协议中允许,但是实际运用中可能存在一些问题。 不过考虑到 upstream 不一定是域名,也可能是 hostname,hostname 的要求就宽松多了,我们有空会改成允许下划线。 |
Released in 6.2.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
upstream域名无法添加下划线
How we reproduce?
如图
![image](https://private-user-images.githubusercontent.com/10370671/347736206-397504e2-cd61-4ee2-919a-fff4b84056e5.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk3NzAwNjMsIm5iZiI6MTczOTc2OTc2MywicGF0aCI6Ii8xMDM3MDY3MS8zNDc3MzYyMDYtMzk3NTA0ZTItY2Q2MS00ZWUyLTkxOWEtZmZmNGI4NDA1NmU1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE3VDA1MjI0M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTEyNTYwMmQxNGY0M2QwM2M1MDA5ZTFkYzRhNTEzMjZkMzFlNjc0MjU1MjcxMGQ4Zjk3OGUyYjVhMGM0OWE1YTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.FEgsJMWe8MOD_JvU9LCC70IbSEGt7pxPNFhkuxu8OVM)
Expected behavior
校验通过
Error log
No response
The text was updated successfully, but these errors were encountered: