-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Claimed support for Node.js v12 missing #150
Comments
Hi, where do you see we support Node 12? |
@Qix- Hi! It is mentioned in the release notes for v9.0.0, the latest major version, and also in Lines 18 to 20 in d4f413e
Actually, v15 is the first major release to support |
Hmm well Node 12 works, I just checked. If there's an issue with Typescript, you'll need to take it up with them. We're not doing anything wrong here. We're not going to remove the namespace, though. Sorry about that. Let me know if I've misunderstood you at all I'll re-open. Thanks for filing! |
@Qix- have you checked in a version prior to v12.20.0 where the |
Hmm I think we had this same question before but I can't find it. Maybe @sindresorhus remembers why we don't have a more specific version in there? |
Found some similar issues:
The right one would be |
It's simply not always feasible to remember the exact minor Node.js version of every feature you use. It is generally expected that users upgrade minor Node.js version for security reasons. The version with this has been out for more than 2 years now and no one else has complained about this, so it's clear it's not a big issue. |
Node.js 14 is not in maintenance mode. It's not supported at all, even by the Node.js team. The general convention in the community is to support the last active LTS version, which is Node.js 16. https://nodejs.dev/en/about/releases/ |
Oh, that's right, I had mixed them up, sorry. |
Closing as we don't intend to change anything here. The next version (when we have any new changes to push out) of this package will be to target Node.js 16. |
The
node:
namespace imports used by the library were backported to Node.js v12, see nodejs/node#35757.They are also only supported by
@types/node
starting v16, see DefinitelyTyped/DefinitelyTyped#52595 (comment). That has the following TypeScript error as a consequence when trying to use the newest library version in jestjs/jest codebase that relies on"@types/node": "~14.14.45"
:Please consider giving up the use of the namespace.
The text was updated successfully, but these errors were encountered: