Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.1 breaks null and undefined states #7

Closed
wopian opened this issue Oct 20, 2017 · 1 comment
Closed

0.2.1 breaks null and undefined states #7

wopian opened this issue Oct 20, 2017 · 1 comment

Comments

@wopian
Copy link

wopian commented Oct 20, 2017

0.2.1 switched to deep-assign which was deprecated 2 years ago (its essentially completely broken) and also doesn't handle null and undefined data types. merge-options should be used instead.

Uncaught TypeError: Cannot convert undefined or null to object (token)
    at assignKey (index.js?e77e:23)
    at assign (index.js?e77e:43)
    at assignKey (index.js?e77e:30)
    at assign (index.js?e77e:43)
    at deepAssign (index.js?e77e:64)
    at VuexPersistence.plugin (index.js?bff2:54)
    at eval (vuex.esm.js?358c:351)
    at Array.forEach (<anonymous>)
    at new Store (vuex.esm.js?358c:351)
    at eval (index.js?e3b1:63)

Where the state is:

const state = {
  token: null
}

Would also be a good idea to get a state with all 7 data types added to tests to prevent issues like this in the future

@wopian wopian changed the title 0.2.1 breaks null states 0.2.1 breaks null and undefined states Oct 20, 2017
@championswimmer
Copy link
Owner

This is fixed now
Will cut a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants