Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PPO #272

Merged
merged 86 commits into from
Mar 28, 2023
Merged

PPO #272

merged 86 commits into from
Mar 28, 2023

Conversation

kshitijkg
Copy link
Collaborator

@kshitijkg kshitijkg commented May 3, 2022 •
edited
Loading

PR that implements:

  • PPO
  • Normalization Wrappers
  • Gym Wrappers

This was linked to issues May 3, 2022
Buffer for on-policy algorithms like PPO, TRPO #271
Open
Add PPO Agent #253
Open
@kshitijkg kshitijkg requested a review from dapatil211 May 3, 2022 06:05
@dapatil211 dapatil211 changed the base branch from dev to spaces May 3, 2022 13:33
sriyash421
sriyash421 reviewed May 3, 2022
View reviewed changes
hive/agents/ppo.py Outdated Show resolved Hide resolved
Base automatically changed from spaces to dev May 4, 2022 20:55
saikrishna-1996
saikrishna-1996 reviewed May 8, 2022
View reviewed changes
hive/agents/ppo.py Outdated Show resolved Hide resolved
kshitijkg
kshitijkg commented May 10, 2022
View reviewed changes
hive/agents/qnets/ppo_nets.py Outdated Show resolved Hide resolved
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/replays/ppo_replay.py Outdated Show resolved Hide resolved
hive/replays/ppo_replay.py Outdated Show resolved Hide resolved
hive/replays/ppo_replay.py Outdated Show resolved Hide resolved
sriyash.poddar and others added 2 commits May 12, 2022 17:41
@dapatil211 dapatil211 added the major Major PRs label May 20, 2022
dapatil211
dapatil211 requested changes Jan 19, 2023
View reviewed changes
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/envs/gym_env.py Outdated Show resolved Hide resolved
hive/replays/ppo_replay.py Outdated Show resolved Hide resolved
hive/replays/ppo_replay.py Outdated Show resolved Hide resolved
hive/replays/ppo_replay.py Outdated Show resolved Hide resolved
hive/replays/ppo_replay.py Outdated Show resolved Hide resolved
dapatil211
dapatil211 requested changes Feb 6, 2023
View reviewed changes
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/agents/qnets/normalizer.py Outdated Show resolved Hide resolved
hive/envs/env_wrapper.py Outdated Show resolved Hide resolved
hive/envs/gym_env.py Outdated Show resolved Hide resolved
hive/replays/on_policy_replay.py Outdated Show resolved Hide resolved
hive/replays/on_policy_replay.py Outdated Show resolved Hide resolved
hive/runners/single_agent_loop.py Show resolved Hide resolved
dapatil211
dapatil211 requested changes Feb 8, 2023
View reviewed changes
Copy link
Collaborator

@dapatil211 dapatil211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of other changes

hive/envs/gym_env.py Outdated Show resolved Hide resolved
hive/envs/gym_env.py Outdated Show resolved Hide resolved
@dapatil211 dapatil211 mentioned this pull request Feb 28, 2023
Closed
dapatil211
dapatil211 requested changes Mar 21, 2023
View reviewed changes
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/agents/ppo.py Outdated Show resolved Hide resolved
hive/agents/qnets/normalizer.py Outdated Show resolved Hide resolved
hive/agents/qnets/normalizer.py Outdated Show resolved Hide resolved
hive/agents/qnets/normalizer.py Outdated Show resolved Hide resolved
hive/agents/qnets/ppo_nets.py Outdated Show resolved Hide resolved
hive/envs/gym_env.py Outdated Show resolved Hide resolved
hive/replays/on_policy_replay.py Outdated Show resolved Hide resolved
@dapatil211 dapatil211 merged commit 06c485c into dev Mar 28, 2023
@dapatil211 dapatil211 deleted the ppo_spaces branch March 28, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikrishna-1996 saikrishna-1996 saikrishna-1996 left review comments

@hnekoeiq hnekoeiq hnekoeiq requested changes

@sriyash421 sriyash421 sriyash421 left review comments

@dapatil211 dapatil211 dapatil211 requested changes

@alirahkay alirahkay Awaiting requested review from alirahkay

Assignees
No one assigned
Labels
major Major PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buffer for on-policy algorithms like PPO, TRPO Add PPO Agent
5 participants
@kshitijkg @sriyash421 @dapatil211 @saikrishna-1996 @hnekoeiq