Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Continuous Deployment Support #430

Open
EduardoAC opened this issue Dec 12, 2024 · 1 comment
Open

RFC: Continuous Deployment Support #430

EduardoAC opened this issue Dec 12, 2024 · 1 comment

Comments

@EduardoAC
Copy link

Current behaviour

  • We need to create a new branch and then attempt to merge that branch to trigger the publish

These have the following deficiencies:

  • GitHub Actions doesn't trigger CI when the Octokit API creates the PR
  • GitHub Actions workflow_run only applies to the branch where the version is triggered and not the PR generated.
  • The fact that we need to cherry-pick when to yarn install without --immutable flag

Desire behaviour

Adding a flag called continousDeployment that allows to trigger on PR merge the following steps:

  • Trigger version
  • Create a commit on the main with the changes
  • Trigger publish

I understand this has downsides and caveats. The idea behind it follows the same philosophy as the article Continuous deployments with Changesets + GitHub actions within the action itself rather than requiring additional setup.

Before starting work on a PoC, I would like to hear your thoughts and if it will bring value.

@EduardoAC EduardoAC changed the title Continuous Deployment Support RFC: Continuous Deployment Support Dec 12, 2024
@jbrunton
Copy link

jbrunton commented Dec 29, 2024

I found this issue because I was trying to figure out if I could configure the GitHub action to do just this. For me, the extra branching and PR steps are just additional hoops to jump through. I'd much rather have the new versions be automatically published by CI.

I understand why an OSS project might favour additional time to test and bake the main branch with a manual release mechanism, but for an internal team a continuous delivery paradigm often makes more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants