Fix: TypeError: 'requestAnimationFrame' called on an object that does not implement interface Window. #322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 96.36% 96.36%
=======================================
Files 32 32
Lines 1156 1156
Branches 216 216
=======================================
Hits 1114 1114
Misses 38 38
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
chanind
approved these changes
Nov 13, 2024
|
🎉 This PR is included in version 3.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Firefox 132.0.1 (aarch64) on macOS, I get this error:
TypeError: 'requestAnimationFrame' called on an object that does not implement interface Window.(fromMutation.tsline 134)And the same error for
cancelAnimationFrameI don't get that error on Safari or Chrome on the same machine.
Binding them to the global object fixes that error for me.