feat: add default tags to AWS provider #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakeyheath
requested review from
beroy,
alexlokshin-czi and
dtsai-czi
and removed request for
a team and
beroy
dtsai-czi
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This feature adds defaults tags to all the AWS providers. It will include information about the Git SHA and branch that are provided by TFE. If these variables are not provided, they default to 'unknown'. This PR also adds helper scripts to the fogg repositories so that we can start leveraging them in other ways to tag all our resources.
Note
gitcommands to essentially not work. We will try to address this in a different feature (maybe using Github Actions to trigger plans/applies instead).