Check plugin version before indexing #624
Conversation
… api race condition
lgan-czi
dismissed
their stale review
Wait hang on, I remember we used get_plugin_pypi_metadata somewhere else too, would that get affected?
|
The other place it's used is in is preview.py, not sure if preview.py is affected by the non-versioned pypi API not updating correctly |
There was a problem hiding this comment.
@potating-potato Thanks for looking into this! Some questions/thoughts:
Is the idea that we would wait for PyPI's non-versioned endpoint to "catch up" to the latest release? #611 was originally opened due to an observed lag (>4 hours) before certain plugins were showing up at all on the hub (see #611 (comment)). Do you think this lag is due to this issue with PyPI's non-versioned endpoint being out of date? If so, we would still expect this lag to continue, right?
I'm okay with merging this to fix the particular versioning conflict issue you summarized in #611 (comment), but let's leave #611 open so we can also address the lag -- it seems like PyPI's non-versioned endpoint isn't as reliable as we might've thought, and we might need to consider implementing option 2 in #608 sooner than later.
Yes we would still expect this lag to continue, right? I am assuming so at the moment, I will keep 611 open |
this address some problems identified in #611
perform a version check when indexing plugin metadata to prevent pypi api race condition, where the listing reports a newer version but history API is not up to date to use that version.