-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Improve Cloud Chaos Providers #46
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c457948
to
f9da8a0
Compare
Signed-off-by: Mike Tonks <michael.tonks@form3.tech>
Signed-off-by: Mike Tonks <michael.tonks@form3.tech>
Signed-off-by: Mike Tonks <michael.tonks@form3.tech>
383e388
to
da07747
Compare
Supported filters are defined in the AWS SDK. For details see: | ||
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeInstances.html | ||
|
||
### GCP Chaos selecting multiple instances using labels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For GCP and Azure, could you provide the related docs like
https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_DescribeInstances.html please? ❤️
It might be necessary to make breaking changes to the structures, so it | ||
in this case it would be easier to introduce new types and eventually | ||
deprecate the old ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems only introducing new filters would NOT take breaking changes, it's fine. Or do I miss something?
It might be necessary to introduce new chaos types e.g. AWSNetworkChaos, | ||
GCPNetworkChaos and so on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I prefer to introduce new chaos type, also in other words, new CRDs.
it's OK, and it is also one of the benefits that Chaos Mesh bring with declarative API: clear spec/status.
Signed-off-by: Mike Tonks <michael.tonks@form3.tech>
Initial thoughts about improving the support for chaos experiments using cloud providers infrastructure.
preview