-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation improvements for the List
module
#18111
Comments
My main worry is that someone will miss the warning if they enter the documentation at a particular method rather than from the start of the module documentation. But having a quick link to a longer warning would also help with that.
Personally, I've found having operator overloads defined explicitly on a type helpful in other languages. Especially when the operator takes the type for one side of a binary operation and another type for the other. It might also be useful to have chpldoc make a separate section for operators, but I think that's dependent on #5946 |
I agree with the other line items :) |
I think this is a reasonable point. One potential compromise is to have "lighter-weight" warnings, that doesn't take up so much space, or maybe collapsible ones. Arguable that's a lot of effort though.
I agree that there should be some documentation, and would think that separate operators section (that we probably render a little differently) would make great sense. And until then we may have to keep what we have. |
The following are some notes that I took while reviewing the
List
interface. I think some of them are open to discussion and are related to our general documentation strategy. But here's what I think personally:proc size
andproc indices
closer to the beginning.(1) Implement a generic version that gives a verbose compiler error,
(2) document that version, listing alternative types that can be passed,
(3) no-doc actual implementations?
remove
documentation should specify what happens ifcount
is larger than the count of elements actually in the list. (I am assuming silently return the actual number that's less thancount
is returned?)readWriteThis
?list
type supports those operators. But it may be just me.The text was updated successfully, but these errors were encountered: