Internal error using first class functions in map

[bmcdonald3]

Summary

When the type of a FCF is used to construct a map and then that function is added to the map it will cause an internal error. If you declare a function, use its type to construct the map, and then pass a different function, that works as expected.

This causes an internal error:

use Map;
proc myF() {
  return 1;
}
var m: map(string, myF.type);
m.add("asd", myF);

This does not:

use Map;
proc myF() {
  return 1;
}

proc myF2() {
  return 2;
}

var m: map(string, myF.type);
m.add("asd", myF2);

[bradcray]

Compiling this test with --verify flags an error:

testit.chpl:1: In module 'testit':
testit.chpl:6: internal error: SymExpr::verify      1336588:  var->defPoint is not in AST [AST/expr.cpp:572]

suggesting to me that we're probably referring to something after pulling it out of the AST. However, recompiling with --no-dead-code-elimination doesn't help, so something else must be going on... I'm probably going to time out on this before coming to any conclusion, but wanted to note this observation first.