Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JoinHorizontal should use top/bottom not left/right #553

Closed
shaunco opened this issue Jul 13, 2024 · 4 comments · Fixed by #577
Closed

JoinHorizontal should use top/bottom not left/right #553

shaunco opened this issue Jul 13, 2024 · 4 comments · Fixed by #577
Labels
good first issue Good for newcomers

Comments

@shaunco
Copy link

shaunco commented Jul 13, 2024

These JoinHorizontal calls should use lipgloss.Top rather than lipgloss.Left:

@aditipatelpro
Copy link
Contributor

@shaunco , I would love to contribute to this project and this issue seems interesting to start with.
I would love to start working on this if you are open for contributions.

@shaunco
Copy link
Author

shaunco commented Jul 17, 2024

@aditipatelpro I am just a user of charmbracelet, not a maintainer but it appears that the project accepts plenty of outside PRs.

@aditipatelpro
Copy link
Contributor

Thank you @shaunco.

@muesli @meowgorithm @aymanbagabas, I am interested in contributing to this project and would love to start working on it if you are open to it.

@bashbunni
Copy link
Member

@aditipatelpro if you would like to contribute a fix for this, please do! We appreciate all of the contributions we get :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants