From 82d5785169239b33dd4d1e58094fdd7e6ca2697c Mon Sep 17 00:00:00 2001
From: Ayman Bagabas <ayman.bagabas@gmail.com>
Date: Thu, 24 Oct 2024 16:03:43 -0400
Subject: [PATCH] fix(ci): add lint and lint-sync workflows and update
 golangci.yml

---
 .github/workflows/lint-soft.yml | 28 ---------------------
 .github/workflows/lint-sync.yml | 14 +++++++++++
 .github/workflows/lint.yml      | 24 ++----------------
 .golangci-soft.yml              | 44 ---------------------------------
 .golangci.yml                   |  4 ---
 5 files changed, 16 insertions(+), 98 deletions(-)
 delete mode 100644 .github/workflows/lint-soft.yml
 create mode 100644 .github/workflows/lint-sync.yml
 delete mode 100644 .golangci-soft.yml

diff --git a/.github/workflows/lint-soft.yml b/.github/workflows/lint-soft.yml
deleted file mode 100644
index 2eb25262d..000000000
--- a/.github/workflows/lint-soft.yml
+++ /dev/null
@@ -1,28 +0,0 @@
-name: lint-soft
-on:
-  push:
-  pull_request:
-
-permissions:
-  contents: read
-  # Optional: allow read access to pull request. Use with `only-new-issues` option.
-  pull-requests: read
-
-jobs:
-  golangci:
-    name: lint-soft
-    runs-on: ubuntu-latest
-    steps:
-      - name: Install Go
-        uses: actions/setup-go@v5
-        with:
-          go-version: ^1.18
-
-      - uses: actions/checkout@v4
-      - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6
-        with:
-          # Optional: golangci-lint command line arguments.
-          args: --config .golangci-soft.yml --issues-exit-code=0
-          # Optional: show only new issues if it's a pull request. The default value is `false`.
-          only-new-issues: true
diff --git a/.github/workflows/lint-sync.yml b/.github/workflows/lint-sync.yml
new file mode 100644
index 000000000..ecf858024
--- /dev/null
+++ b/.github/workflows/lint-sync.yml
@@ -0,0 +1,14 @@
+name: lint-sync
+on:
+  schedule:
+    # every Sunday at midnight
+    - cron: "0 0 * * 0"
+  workflow_dispatch: # allows manual triggering
+
+permissions:
+  contents: write
+  pull-requests: write
+
+jobs:
+  lint:
+    uses: charmbracelet/meta/.github/workflows/lint-sync.yml@main
diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index 86612f09e..a1d6d0e51 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -3,26 +3,6 @@ on:
   push:
   pull_request:
 
-permissions:
-  contents: read
-  # Optional: allow read access to pull request. Use with `only-new-issues` option.
-  pull-requests: read
-
 jobs:
-  golangci:
-    name: lint
-    runs-on: ubuntu-latest
-    steps:
-      - name: Install Go
-        uses: actions/setup-go@v5
-        with:
-          go-version: ^1.18
-
-      - uses: actions/checkout@v4
-      - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6
-        with:
-          # Optional: golangci-lint command line arguments.
-          #args:
-          # Optional: show only new issues if it's a pull request. The default value is `false`.
-          only-new-issues: true
+  lint:
+    uses: charmbracelet/meta/.github/workflows/lint.yml@main
diff --git a/.golangci-soft.yml b/.golangci-soft.yml
deleted file mode 100644
index d11d36b7a..000000000
--- a/.golangci-soft.yml
+++ /dev/null
@@ -1,44 +0,0 @@
-run:
-  tests: false
-
-issues:
-  include:
-    - EXC0001
-    - EXC0005
-    - EXC0011
-    - EXC0012
-    - EXC0013
-
-  max-issues-per-linter: 0
-  max-same-issues: 0
-
-linters:
-  enable:
-    # - dupl
-    - exhaustive
-    # - exhaustivestruct
-    - goconst
-    - godot
-    - godox
-    - mnd
-    - gomoddirectives
-    - goprintffuncname
-    # - lll
-    - misspell
-    - nakedret
-    - nestif
-    - noctx
-    - nolintlint
-    - prealloc
-    - wrapcheck
-
-  # disable default linters, they are already enabled in .golangci.yml
-  disable:
-    - errcheck
-    - gosimple
-    - govet
-    - ineffassign
-    - staticcheck
-    - typecheck
-    - unused
-    - predeclared
diff --git a/.golangci.yml b/.golangci.yml
index 4e2ea0268..d6789e014 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -15,7 +15,6 @@ issues:
 linters:
   enable:
     - bodyclose
-    - copyloopvar
     - gofumpt
     - goimports
     - gosec
@@ -27,6 +26,3 @@ linters:
     - unconvert
     - unparam
     - whitespace
-    # We're disabling predeclared because the linter is running a newer version
-    # of Go than then Go module.
-    # - predeclared