You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for making VHS and sharing it as Software Libre! 🙏 It made me go "wow!" when I first saw it and both the tool and the language reference are very nice — thanks! 🙏
One thing I ran into is that when I combine Screenshot <file> with Type "<text>", the screenshot may already include letters of the Type that came after it. So to reproduce it needs nothing but…
Screenshot screenshot.png
Type "hello vhs"
…and a bit of luck running it a few times. In my case I saw the very first letter typed in the screenshot, so that would be "h" here. When I just tried it again locally, the issue showed at first try:
A workaround seems to be to add Sleep 0.2s after the screenshot, but maybe I just have not seen it fail yet and soon will. In any case the current behavior of Screenshot including things from the future makes CI stability hard and is unexpected from a user point of view. Maybe it's considered worth investigating and fixing.
PS: When Screenshot is the last command in the .tape file, VHS does not create that file at all while saying so. Seems to be related. Again, adding Sleep 0.2s works around the problem.
Describe the bug
Hi!
Thanks for making VHS and sharing it as Software Libre! 🙏 It made me go "wow!" when I first saw it and both the tool and the language reference are very nice — thanks! 🙏
One thing I ran into is that when I combine
Screenshot <file>
withType "<text>"
, the screenshot may already include letters of theType
that came after it. So to reproduce it needs nothing but……and a bit of luck running it a few times. In my case I saw the very first letter typed in the screenshot, so that would be "h" here. When I just tried it again locally, the issue showed at first try:
screenshot.png
shows……which proves my point.
A workaround seems to be to add
Sleep 0.2s
after the screenshot, but maybe I just have not seen it fail yet and soon will. In any case the current behavior ofScreenshot
including things from the future makes CI stability hard and is unexpected from a user point of view. Maybe it's considered worth investigating and fixing.Best, Sebastian
CC @elmarsan
PS: When
Screenshot
is the last command in the.tape
file, VHS does not create that file at all while saying so. Seems to be related. Again, addingSleep 0.2s
works around the problem.PPS: Related? #70
Setup
To Reproduce
Use
Screenshot
followed byType
directly in a.tape
file, then inspect the screenshot to find typing from the future.Source Code
Expected behavior
The screenshot is fully saved before VHS continues typing.
Screenshots
n/a
Additional context
n/a
The text was updated successfully, but these errors were encountered: