Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The default value for aspectRatio of the document seems to be wrong #10398

Closed
1 of 3 tasks
gmldnjs26 opened this issue Jun 5, 2022 · 1 comment · Fixed by #10456
Closed
1 of 3 tasks

The default value for aspectRatio of the document seems to be wrong #10398

gmldnjs26 opened this issue Jun 5, 2022 · 1 comment · Fixed by #10456
Labels
type: documentation

Comments

@gmldnjs26
Copy link

gmldnjs26 commented Jun 5, 2022 •
edited
Loading

Documentation Is:

  • Missing or needed?
  • Confusing
  • Not sure?

Please Explain in Detail...

The document says the default value of aspectRatio is 2, but it is actually operating at 1
Chart.js/src/docs/configuration/responsive.md

(In version 2, the default value seems to be 2)

Your Proposal for Changes

I think the document is wrong, but I want to change the default value to 1

Example

No response
@kurkle
Copy link
Member

kurkle commented Jun 29, 2022

Looks like its only mentioned in migration guide:

aspectRatio defaults to 1 for doughnut, pie, polarArea, and radar charts

@kurkle kurkle mentioned this issue Jun 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update aspectRatio documentation kurkle/Chart.js
2 participants
@kurkle @gmldnjs26