Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint to latest version #11951

Open
benmccann opened this issue Nov 13, 2024 · 5 comments
Open

Upgrade eslint to latest version #11951

benmccann opened this issue Nov 13, 2024 · 5 comments

Comments

@benmccann
Copy link
Contributor

benmccann commented Nov 13, 2024

Feature Proposal

Upgrade eslint and all the eslint plugins to the latest version. I maintain some chartjs packages that I can't upgrade until this repo upgrades because eslint-config-chartjs uses old syntax

Possible Implementation

Migrate this repo and eslint-config-chartjs to flat config. Upgrade eslint and eslint plugins

@etimberg
Copy link
Member

@benmccann makes sense. Happy to look at PRs for that

@etimberg
Copy link
Member

Also, great to hear from you again 😄

@benmccann
Copy link
Contributor Author

Nice to see you as well 😄

I actually found out there's a compatibility layer, so I think I can keep using the old eslint-config-chartjs for the time being. We should probably still update it, but I'm not sure if I'll have time seeing as how I've found a workaround for now

One thing I did find that I'll mention here to perhaps save some time is that on https://www.chartjs.org/docs/latest/api/interfaces/ChartTypeRegistry.html where there is {} it seems it should be replaced with Record<string, never>

@etimberg
Copy link
Member

Yeah, I can see that being a useful change. Will see if I can find time to get to it as I don't have a lot of time for opensource lately

@benmccann
Copy link
Contributor Author

Something else I found that will help is that eslint-plugin-es is no longer maintained, but there's a better maintained fork called eslint-plugin-es-x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants