Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure getRightValue returns the parsed value #5949

Closed
benmccann opened this issue Jan 1, 2019 · 2 comments
Closed

Ensure getRightValue returns the parsed value #5949

benmccann opened this issue Jan 1, 2019 · 2 comments
Labels
breaking change
Milestone
Version 3.0

Comments

@benmccann
Copy link
Contributor

benmccann commented Jan 1, 2019 •
edited
Loading

It may return the original value today which means we may need to do something like a conversion from string to number everywhere it is called. See #5947 (review)
@benmccann benmccann added this to the Version 3.0 milestone Jan 1, 2019
@simonbrunel simonbrunel mentioned this issue Jan 1, 2019
Merged
@benmccann benmccann changed the title Ensure getRightValue returns a number Ensure getRightValue returns the parsed value Jan 1, 2019
@etimberg
Copy link
Member

etimberg commented Jan 5, 2020

@benmccann is this still relevant?

@benmccann
Copy link
Contributor Author

No. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
Version 3.0
Development

No branches or pull requests
2 participants
@benmccann @etimberg