-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_maxLabelLines undefined in master #6095
Comments
does that fix it for you in your development branch: |
That doesn't seem right to me. Shouldn't we use the actual number of label lines instead of |
Not sure what you are working towards, but I don't think you need to consider label height if its not visible. |
It looks like there are different options for tick and grid line visibility. What if ticks are not visible, but grid lines are? |
Though it looks like Perhaps we could change from:
To:
|
Regression from #5922
_maxLabelLines
is set only whentickOpts.display && display
, which causes aNaN
due to_maxLabelLines
beingundefined
in_tickSize
Chart.js/src/core/core.scale.js
Line 430 in 79fc340
Chart.js/src/core/core.scale.js
Line 686 in 79fc340
The text was updated successfully, but these errors were encountered: