Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce unit test based on image comparison #3988

Merged
merged 1 commit into from
Mar 5, 2017
Merged

Introduce unit test based on image comparison #3988

merged 1 commit into from
Mar 5, 2017

Commits on Mar 5, 2017

  1. Introduce unit test based on image comparison 

    Attempt to make easier the creation of unit tests that check the drawing output. Until now, this was done by checking calls on a 'fake' context, which is hard to maintain (need to update pixel values by hands) and also not reliable when optimizing code (i.e. different calls sequence but same result).

As of now, it's possible to define 'auto' tests based on JSON/PNG fixtures: chart is generated from the JSON file and compared to the associated PNG image. The image diff is done using `pixelmatch`. As an example (and in preparation of the `filler` plugin), add auto tests for the line element `fill` options.
    @simonbrunel
    simonbrunel committed Mar 5, 2017
    Configuration menu
    Copy the full SHA
    5477996 View commit details
    Browse the repository at this point in the history