Fix bug when data is all small numbers #5723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etimberg
approved these changes
Sep 9, 2018
simonbrunel
approved these changes
Sep 16, 2018
|
Thanks @costerwi |
exwm
pushed a commit
to exwm/Chart.js
that referenced
this pull request
Apr 30, 2021
* Add test for correct handling of small numbers * Calculate tick precision for arbitrarily small numbers * Use scientific notation for very small tick numbers * Calculate significant digits for exponential tick values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5653 where nothing would be plotted if the tick spacing (increment between tick marks) came out too small such as when all the data is nearly zero as in this example
The proposed change permits plotting of data down to very small values using scientific notation.
Besides the fix, I also added a test which flags the problem.