Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent use of punctuation and quick review in docs #5796

Merged
merged 2 commits into from
Nov 2, 2018
Merged

Consistent use of punctuation and quick review in docs #5796

merged 2 commits into from
Nov 2, 2018

Conversation

bartdeslagmulder
Copy link
Contributor

No description provided.

benmccann
benmccann previously approved these changes Oct 31, 2018
@benmccann
Copy link
Contributor

I don't feel like this PR is creating a lot of value, but it isn't hurting anything either. I'm fine to either merge or close as the other maintainers see fit

Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bartdeslagmulder, can you please address my few comments?

I'm fine with merging this PR since it brings more consistency in the doc.

docs/configuration/tooltip.md Outdated Show resolved Hide resolved
docs/axes/cartesian/time.md Show resolved Hide resolved
docs/axes/cartesian/time.md Show resolved Hide resolved
docs/configuration/legend.md Outdated Show resolved Hide resolved
docs/configuration/title.md Outdated Show resolved Hide resolved
docs/configuration/tooltip.md Outdated Show resolved Hide resolved
@bartdeslagmulder
Copy link
Contributor Author

@simonbrunel done!

Copy link
Member

@simonbrunel simonbrunel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants