From eaa52589df5708d78dfd02a1fa9f8994dd7909e8 Mon Sep 17 00:00:00 2001 From: Jukka Kurkela Date: Wed, 23 Jan 2019 07:27:57 +0200 Subject: [PATCH 1/2] supply correct start parameter to insertElements --- src/core/core.datasetController.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/core/core.datasetController.js b/src/core/core.datasetController.js index 303549849ae..df57a14f8b2 100644 --- a/src/core/core.datasetController.js +++ b/src/core/core.datasetController.js @@ -319,7 +319,9 @@ helpers.extend(DatasetController.prototype, { * @private */ onDataPush: function() { - this.insertElements(this.getDataset().data.length - 1, arguments.length); + var me = this; + var count = arguments.length; + me.insertElements(me.getDataset().data.length - count, count); }, /** From c6807fb1cc4914037fd334ba97e34303ab647d4d Mon Sep 17 00:00:00 2001 From: Jukka Kurkela Date: Wed, 23 Jan 2019 22:41:00 +0200 Subject: [PATCH 2/2] remove caching of `this` --- src/core/core.datasetController.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/core/core.datasetController.js b/src/core/core.datasetController.js index df57a14f8b2..6a7d36f196b 100644 --- a/src/core/core.datasetController.js +++ b/src/core/core.datasetController.js @@ -319,9 +319,8 @@ helpers.extend(DatasetController.prototype, { * @private */ onDataPush: function() { - var me = this; var count = arguments.length; - me.insertElements(me.getDataset().data.length - count, count); + this.insertElements(this.getDataset().data.length - count, count); }, /**