Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logarithmic test to use correct scale #6580

Merged
merged 1 commit into from
Oct 19, 2019
Merged

Fix logarithmic test to use correct scale #6580

merged 1 commit into from
Oct 19, 2019

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Oct 19, 2019

Test using correct scale. Using a scale that is not attached to given dataset should really not return any label for it.

This is extracted from #6576 to make the reviewing easier.

benmccann
benmccann approved these changes Oct 19, 2019
View reviewed changes
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the commit message, but otherwise looks good

@kurkle kurkle changed the title Fix logarighmic test to use correct scale Fix logarithmic test to use correct scale Oct 19, 2019
@etimberg etimberg merged commit d386013 into chartjs:master Oct 19, 2019
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
@kurkle kurkle deleted the test-use-correct-scale branch November 13, 2019 06:12
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@kurkle @etimberg
Fix logarighmic test to use correct scale (chartjs#6580)
fe5d1ee
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@benmccann benmccann benmccann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kurkle @benmccann @etimberg