[next] esm build not in dist

[hsablonniere]

Hi team,

I'm migrating from chart.js v2 to v3 and I'm looking forward to have good ESM and treeshaking support.
I've been using this plugin so I tried the 2.0.0-rc.

It works but my the ESM file referenced in the package.json is not in my node_modules after installation.

This means my rollup configuration:

• picks up the default CJS file in dist
• which does a require('chart.js')
• which imports the whole lib
• and thus prevents treeshaking

I may be mistaken but I think the rollup config is in conflict here: https://github.com/chartjs/chartjs-plugin-datalabels/blob/next/rollup.config.js#L48

How can I help?

[hsablonniere]

I just cloned the project, I can prepare a PR if you want ;-)

[hsablonniere]

I was still on master. Sorry.

[hsablonniere]

The build correctly generates the esm file.

[hsablonniere]

It's weird because the package.json is OK and the npm pack --dry-run has the ESM file.

[simonbrunel]

Thanks @hsablonniere! The .esm.js file is missing in the attach-gh-assets.js and create-release-tag.js scripts.

[hsablonniere]

@simonbrunel Ah ok. I looked at some scripts but not those...

Thanks for your work and the plugin in general ;-)

We use it in our components library: https://www.clever-cloud.com/doc/clever-components/?path=/story/%F0%9F%9B%A0-overview-cc-tile-requests--default-story

[hsablonniere]

Do you want a PR?

[simonbrunel]

This is fixed by 0870ebe, released in v2.0.0-rc.1.

The ESM build is now correctly:

• pushed to the tag
• attached to the GH release
• published to npm
• available on jsdelivr

[hsablonniere]

You are awesome, thanks very much Simon 😍👍👏