Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Will this be updated to be compatible with ChartJS 3.0? #15

Closed
jackyaz opened this issue Apr 1, 2020 · 7 comments · Fixed by #21
Closed

Will this be updated to be compatible with ChartJS 3.0? #15

jackyaz opened this issue Apr 1, 2020 · 7 comments · Fixed by #21

Comments

@jackyaz
Copy link

jackyaz commented Apr 1, 2020

No description provided.

@gregh3269
Copy link

gregh3269 commented Apr 15, 2021

v3.1.0 I get
Uncaught TypeError: Chart.defaults.global is undefined
/**

Cheers

@john-rock
Copy link

Chartjs version: 3.3.2
Plugin version: 1.0.2

I'm getting - e.defaults.global is undefined

@gregh3269
Copy link

Would be good to get this fixed as @2.9.4 is the last version plug-in works on.

@cysieks
Copy link

cysieks commented Jul 24, 2021

I was able to make it work with chart js 3:
Here is fork: https://github.com/cysieks/chartjs-plugin-deferred

@gregh3269
Copy link

gregh3269 commented Jul 25, 2021

@cysieks great, works now, but load does not seem to be deferred and loads immediately? (rechecked)

@mloit
Copy link

mloit commented Jul 29, 2021

The parameter lists for the beforeInit, and beforeDatasetsUpdate are incorrect. As coded they are (chart, options), but they need to be (chart, args, options) for the options to be seen, without it it is defaulting to 0 because it thinks they are undefined.. Changing that seems to have made it work for me. I had to make some other changes to get it to load, but once i did that, it all seems to work now. @cysieks thanks for the fork!

I'm still chasing down another issue. Using the plugin seems to trigger an onComplete event for the chart immediately on load, which causes a problem for me as I have some other code dependent on that event happening when the chart is drawn. But thanks to this fork, things are moving forward.

@simonbrunel simonbrunel linked a pull request Dec 31, 2021 that will close this issue
@simonbrunel simonbrunel added this to the Version 2.0 milestone Dec 31, 2021
@simonbrunel
Copy link
Member

Version 2.0.0-beta.1 has been released and is compatible with Chart.js v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants