Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve devfile:generate command #100

Closed
11 tasks
l0rd opened this issue May 13, 2019 · 3 comments
Closed
11 tasks

Improve devfile:generate command #100

l0rd opened this issue May 13, 2019 · 3 comments

Comments

@l0rd
Copy link
Collaborator

l0rd commented May 13, 2019

  • Support config maps
  • Better input sanity check: verify that a plugin provided as a parameter has a valid format
  • Find a better way to generate src/api/devfile.ts (currently done via quicktype.io)
  • complete devfile/generate.test.ts
    • make nock work
    • parse yaml output and verifies, for each kind, the number of items and the fields that should exist and those that should not.
  • Add an e2e test:
    kubectl create namespace prod
    kubens prod
    kubectl apply -f https://raw.githubusercontent.com/sleshchenko/NodeJS-Sample-App/dockerCon/deploy_k8s.yaml
    chectl devfile:generate \
            --selector="app.kubernetes.io/name=employee-manager" \
            --language=typescript \
            --git-repo='https://github.com/sleshchenko/NodeJS-Sample-App.git'
    kubectl delete services --all -n prod
    kubectl delete deployment --all -n prod
  • Support specifying multiple selectors (e.g. --selector="name=springboot" --selector="name=mysql")
  • Support specifying multiple languages (e.g. --language=java --language=go)
  • Support specifying multiple plugins
  • Support --file as an alternative to --namespace as a source for k8s resources
@sleshchenko
Copy link
Contributor

@l0rd I think it makes sense to support generating a devfile from a file as well. For example, for this Demo project https://github.com/sleshchenko/NodeJS-Sample-App it would look like the following

chectl devfile:generate \
        --file=deploy_k8s.yaml
        --language=typescript \
        --git-repo='https://github.com/sleshchenko/NodeJS-Sample-App.git'

And then generated Devfile may reference this file instead of inlining content.
WDYT?

@l0rd
Copy link
Collaborator Author

l0rd commented May 15, 2019

Good idea @sleshchenko I have updated the description

@benoitf
Copy link
Collaborator

benoitf commented Sep 9, 2019

Kamino closed and cloned this issue to eclipse/che

@benoitf benoitf closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants