Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace UI flag note markdown editor #392

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

zhouzhuojie
Copy link
Collaborator

Description

Replace mavon-editor with a simple markdown-it editor. With the minimum setup and a simple katex support.

image
image

Motivation and Context

Fix #370

How Has This Been Tested?

Manual tested the edit/view mode, and the history tracking.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Merging #392 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #392   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files          27       27           
  Lines        1755     1755           
=======================================
  Hits         1457     1457           
  Misses        214      214           
  Partials       84       84           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 936e123...c10e97f. Read the comment docs.

@zhouzhuojie zhouzhuojie merged commit 11146d8 into master Sep 4, 2020
@zhouzhuojie zhouzhuojie deleted the zz/replace-markdown-editor branch September 4, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix xss of mavon-editor in flagr UI
2 participants