Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attr converts undefined to string #1664

Closed
fb55 opened this issue Jan 9, 2021 · 1 comment · Fixed by #1757
Closed

attr converts undefined to string #1664

fb55 opened this issue Jan 9, 2021 · 1 comment · Fixed by #1757

Comments

@fb55
Copy link
Member

fb55 commented Jan 9, 2021

jQuery removes attributes when setting their value to undefined, while cheerio sets them to the string 'undefined'.

Discovered in #1659.

@5saviahv
Copy link
Contributor

Notes:

in jQuery if value is specified, but its value is undefined it returns this object

const ret = elems.attr('name', undefined)
// ret == elems

if value is not specified, it tries get first element attribute value, if it is not existing it returns undefined

const ret = elems.attr('name')
// ret == undefined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants