Travis and kitchen-ec2 testing #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpop
force-pushed
the
ap/travis-kitchen
branch
7 times, most recently
from
a114dfd to
6746928
Compare
Signed-off-by: Alex Pop <apop@chef.io>
alexpop
changed the title
chris-rock
approved these changes
Dec 9, 2016
| its(['total']) { should be > 60 } | ||
| end | ||
| # guard the elastic_hits array from index out of bounds exception | ||
| if elastic_hits.length == 2 |
There was a problem hiding this comment.
Should we add an error if the length is not 2?
There was a problem hiding this comment.
I was thinking that this will provide the error:
describe elastic_hits.length do
it { should eq 2 }
end
chris-rock
approved these changes
Dec 9, 2016
| its(['total']) { should be > 60 } | ||
| end | ||
| # guard the elastic_hits array from index out of bounds exception | ||
| if elastic_hits.length == 2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses IAM policy that can only create, tag and terminate own ec2 instances