Handle '@' in username when grabbing compliance profiles #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chris-rock ^^ |
chris-rock
approved these changes
Sep 20, 2017
|
@kevinreedy another approach would be to use a method like https://github.com/chef/inspec/blob/master/lib/bundles/inspec-compliance/api.rb#L203-L211 |
Signed-off-by: Kevin Reedy <kreedy@chef.io>
kevinreedy
force-pushed
the
at-in-user-fix
branch
from
5390e46 to
cbd1b55
Compare
|
Fixed DCO |
arlimus
approved these changes
Sep 27, 2017
arlimus
added a commit
that referenced
this pull request
Sep 27, 2017
As contributed #280 Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
adamleff
pushed a commit
that referenced
this pull request
Sep 27, 2017
As contributed #280 Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Reedykreedy@chef.io
Description
When an Automate user has an
@in their username (like in LDAP or SAML), the profile URL to fetch is incorrect. It is currently resolving tohttps://chefserver.example.com/compliance/organizations/acme/owners/example.com/compliance/cis-windows2012r2-level1-memberserver/tarinstead ofhttps://chefserver.example.com/compliance/organizations/acme/owners/First.Last@example.com/compliance/cis-windows2012r2-level1-memberserver/tarfor example.I went to add new tests, but am confused by the current ones in https://github.com/chef-cookbooks/audit/blob/master/spec/unit/report/fetcher_spec.rb#L33-L37. I'd love to pair with someone Wednesday or early next week on the tests.
Issues Resolved
https://getchef.zendesk.com/agent/tickets/16346
https://chefio.atlassian.net/browse/TRI-549
https://chefio.atlassian.net/browse/BUG-439
Check List