Add support for node['audit']['profiles'] as a hash of hashes #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattray Great work. Should we update the docs to make the hash map the default now? I like the simpler style. |
|
Glad you like it, definitely needed it for Policyfiles. We could add deprecation warnings for array-style usage for a few releases just so we don't blindside anyone. |
|
I agree a deprecation warning would be great. I cannot recall why we went with arrays in the first place, but maps look very nice |
…than an array of hashes. Policyfiles with includes do not allow merging arrays and it's a bit unclear why an array was chosen. This patch does not change the existing behavior, only supplements it. Signed-off-by: Matt Ray <matthewhray@gmail.com>
|
I've updated the PR with a deprecation warning. |
alexpop
approved these changes
Aug 20, 2018
jerryaldrichiii
added a commit
that referenced
this pull request
Feb 13, 2019
Due to #328 we must update the README.md to remove references to the Array of Hashes syntax. ```ruby default['audit']['profiles'] = [] default['audit']['profiles'].push( name: 'example', compliance: 'admin/example' ) ``` becomes ```ruby default['audit']['profiles'] = {} default['audit']['profiles']['example'] = { compliance: 'admin/example' } ``` Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
This was referenced Feb 13, 2019
|
Note #339 where hash of hashes, the new hotness being shown as the replacement for the other 2 methods... doesn't actually work. |
|
@jblaine here's a working example: |
alexpop
pushed a commit
that referenced
this pull request
Sep 18, 2019
Due to #328 we must update the README.md to remove references to the Array of Hashes syntax. ```ruby default['audit']['profiles'] = [] default['audit']['profiles'].push( name: 'example', compliance: 'admin/example' ) ``` becomes ```ruby default['audit']['profiles'] = {} default['audit']['profiles']['example'] = { compliance: 'admin/example' } ``` Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
alexpop
added a commit
that referenced
this pull request
Sep 18, 2019
* Remove deprecated examples using Array of Hashes Due to #328 we must update the README.md to remove references to the Array of Hashes syntax. ```ruby default['audit']['profiles'] = [] default['audit']['profiles'].push( name: 'example', compliance: 'admin/example' ) ``` becomes ```ruby default['audit']['profiles'] = {} default['audit']['profiles']['example'] = { compliance: 'admin/example' } ``` Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com> * Update readme to remove compliance example Signed-off-by: Alex Pop <apop@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Policyfiles with includes do not allow merging arrays and it's a bit unclear why an array was chosen. This patch does not change the existing behavior, only supplements it.
Signed-off-by: Matt Ray matthewhray@gmail.com