Provide option to avoid saving the inspec attributes to the node object #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice! |
jerryaldrichiii
approved these changes
Jun 20, 2019
| # Copies ['audit']['attributes'] into run_state for the audit_handler to read them later | ||
| # Deletes ['audit']['attributes'] if instructed by ['audit']['attributes_save'] | ||
| def copy_audit_attributes | ||
| node.run_state['audit_attributes'] = node['audit']['attributes'] |
| @@ -41,7 +41,8 @@ def report | |||
| end | |||
| quiet = node['audit']['quiet'] | |||
| fetcher = node['audit']['fetcher'] | |||
| attributes = node['audit']['attributes'].to_h | |||
|
|
|||
| attributes = node.run_state['audit_attributes'].to_h | |||
There was a problem hiding this comment.
Going from a Mash to a Hash going to cause any issues? (I know it was a .to_h before, but I'm curious)
There was a problem hiding this comment.
Nobody reported issues with it and tests are showing the expected values.
vjeffrey
approved these changes
Jun 20, 2019
Signed-off-by: Alex Pop <alexpop@users.noreply.github.com>
Signed-off-by: Alex Pop <alexpop@users.noreply.github.com>
alexpop
force-pushed
the
ap/option-to-not-save-attributes
branch
from
5dc94ee to
6dd9a31
Compare
|
Jerry and Victoria, thank you for the reviews! |
Signed-off-by: Alex Pop <alexpop@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing a new cookbook attribute
['audit']['attributes_save']to remove['audit']['attributes']from the node object if needed.Thank you @trickyearlobe for the feedback!
Opening the PR for now while working on tests