Ignore inspec_version for chef client >= 15 #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Pop <alexpop@users.noreply.github.com>
alexpop
added
Type: Bug
teknofire
reviewed
Jul 2, 2019
| @@ -5,7 +5,7 @@ | |||
| license 'Apache-2.0' | |||
| description 'Allows for fetching and executing compliance profiles, and reporting its results' | |||
| long_description IO.read(File.join(File.dirname(__FILE__), 'README.md')) | |||
| version '7.8.0' | |||
| version '8.0.0' | |||
There was a problem hiding this comment.
Should update the README support matrix entry for Chef Client 15 to >= 8.0.0 as well
There was a problem hiding this comment.
Yes, pushed a commit for that, thank you!
miah
approved these changes
Jul 2, 2019
Signed-off-by: Alex Pop <alexpop@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
default['audit']['inspec_version']attribute has been added to the cookbook before chef-client came with an embedded InSpec gem.Currently the
inspec_gemresource of theauditcookbook is uninstalling the existing versions of InSpec and installing the one specified by theinspec_versionattribute. With the release of Chef Infra Client 15, this breaks/opt/chef/bin/chef-clientas can be seen here:I reproduced this issue by converging a node with
Chef Infra Client 15.0.300and theauditcookbook with attributeinspec_versionset to4.6.4. Theinspec_gemresource uninstalled the embeddedinspec-coreversion4.3.2and installed4.6.4.With this PR the audit cookbook ignores the
inspec_versionattribute when Chef Infra Client version 15+ is detected and uses the embedded InSpec gem for the scan. Not breaking chef-client at this moment is more important than using a specific version of InSpec for the scan.