Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated Net::HTTPServerException with Net::HTTPClientException #395

Merged
merged 4 commits into from
Mar 3, 2020
Merged

Update deprecated Net::HTTPServerException with Net::HTTPClientException #395

merged 4 commits into from
Mar 3, 2020

Conversation

kvivek1115
Copy link
Contributor

Replaced Net::HTTPServerException with Net::HTTPClientException
As Net::HTTPServerException is deprecated so used, alised exception class Net::HTTPClientException

Issues Resolved

Fixes #394

Check List

Replace deprecated HTTPServerException net exception class with HTTPC…
c7d60ab 
…lientException

Signed-off-by: Vivek Singh <vivek.singh@msystechnologies.com>
@kvivek1115 kvivek1115 requested a review from a team October 22, 2019 17:54
clintoncwolfe
clintoncwolfe approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@clintoncwolfe clintoncwolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair 'nuff, https://bugs.ruby-lang.org/issues/14688

miah
miah approved these changes Oct 28, 2019
View reviewed changes
Copy link

@miah miah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kvivek1115
Copy link
Contributor Author

when we planing to release these changes?

@vjeffrey vjeffrey mentioned this pull request Mar 2, 2020
Closed
@alexpop alexpop merged commit f314c14 into chef-boneyard:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miah miah miah approved these changes

@clintoncwolfe clintoncwolfe clintoncwolfe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Net::HTTPClientException instead of Net::HTTPServerException
4 participants
@kvivek1115 @miah @clintoncwolfe @alexpop