Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update warnings on size limits, error on nil uuid #417

Merged
merged 4 commits into from
Apr 20, 2020
Merged

Update warnings on size limits, error on nil uuid #417

merged 4 commits into from
Apr 20, 2020

Conversation

btm
Copy link
Contributor

@btm btm commented Apr 15, 2020

  • The default Infra Server limit is 2mb as of 13.0
  • Add a failiure to the cs_automate reporter on a nil uuid that matches the automate reporter
  • Cookstyle fixes

@btm btm requested review from a team, alexpop and tas50 April 15, 2020 15:59
alexpop
alexpop approved these changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@alexpop alexpop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update Bryan, thank you!

btm added 2 commits April 17, 2020 14:50
@btm @alexpop
Update warnings on size limits, error on nil uuid
65b4400 
- The default Infra Server limit is 2mb as of 13.0
- Add a failiure to the cs_automate reporter on a nil uuid that matches the automate reporter

Signed-off-by: Bryan McLellan <btm@loftninjas.org>
@btm @alexpop
Cookstyle fixes
e1b2abf 
Signed-off-by: Bryan McLellan <btm@loftninjas.org>
@alexpop alexpop force-pushed the btm/null-uuid branch 3 times, most recently from 661eefd to e1b2abf Compare April 17, 2020 15:13
alexpop added 2 commits April 17, 2020 17:00
@alexpop
Switch to chef-workstation
8999abd 
Signed-off-by: Alex Pop <apop@chef.io>
@alexpop
Pin chef-infra-client to 15.8.23
ffbd6c0 
Signed-off-by: Alex Pop <apop@chef.io>
@alexpop
Copy link
Contributor

alexpop commented Apr 20, 2020

Test passed after pinning CHEF_VERSION to 15.8.23
As @teknofire pointed out to me, something is fishy with the bundle pry gems in chef 15.9.17

@alexpop alexpop merged commit 0dc8e30 into master Apr 20, 2020
@github-actions github-actions bot deleted the btm/null-uuid branch April 20, 2020 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tas50 tas50 tas50 approved these changes

@alexpop alexpop alexpop approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@btm @alexpop @tas50