Support the Automate /compliance/profiles/metasearch endpoint to send reduced reports #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpop
force-pushed
the
ap/support-metasearch
branch
from
660f48f to
21ecf5f
Compare
vjeffrey
approved these changes
Apr 16, 2020
attributes/default.rb
Outdated
| @@ -88,3 +88,7 @@ | |||
| # <chef_cache_path>/cookbooks/audit/inspec-<YYYYMMDDHHMMSS>.json | |||
| default['audit']['json_file']['location'] = | |||
| File.expand_path(Time.now.utc.strftime('../../inspec-%Y%m%d%H%M%S.json'), __FILE__) | |||
|
|
|||
| # Controls that have a run_time below this limit will be stripped of the `start_time` and | |||
| # `start_time` fields to reduce the size of the reports being sent to Automate | |||
There was a problem hiding this comment.
nitpick: did you mean start time and end time?
There was a problem hiding this comment.
does this mean the report wouldnt have an end time? is that ok with automate ingestion?
There was a problem hiding this comment.
These are for the control results. Let me rephrase the comment to be more clear about this:
# Control results that have a `run_time` below this limit will be stripped of the
# `start_time` and `run_time` fields to reduce the size of the reports being sent to Automate
Signed-off-by: Alex Pop <apop@chef.io>
alexpop
force-pushed
the
ap/support-metasearch
branch
from
b4f4802 to
591f924
Compare
Signed-off-by: Alex Pop <apop@chef.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Automate has recently introduced a new API to check which profiles ids are missing in the database. This API enables the audit cookbook to avoid sending to Automate full reports that can contain up to 90% profile meta information that Automate already has.
Issues Resolved
The Automate(grpc) report limit of 4MB will be harder to reach with this change.