http_rescue not required with tempfile

[Anirudh-Gupta]

Issues Resolved

Throwing error at line 40(libraries->helper.rb) because its not a http request(when integrating with chef server). No response code.

[mhedgpeth]

I'm having this problem as well.

[jejohns]

+1 Thank you!

[cheeseplus]

+1 - adding some detail here from a user's stacktrace that may be related

https://gist.github.com/cheeseplus/83662a441df97ee6f7b5c15454df2405

[smurawski]

Thanks for the PR @Anirudh-Gupta and the confirmations @mhedgpeth @jejohns and @cheeseplus

[jeremymv2]

I don't believe this should have been merged as is. The problem is that it short-circuits the error response code messages by no longer using the with_http_rescue method, which handles errors in the handle_http_error_code method. Now the error handling will no longer occur.

https://github.com/chef-cookbooks/audit/blob/master/libraries/helper.rb#L40

[itmustbejj]

@jeremymv2 As I understand the issue that was addressed, rest.binmode_streaming_request returns a Tempfile object, not an HttpResponse object (probably butchering actual class names). So there is no code attribute to check on the Tempfile object. I think with_http_rescue should not have been there in the first place.

[itmustbejj]

@jeremymv2 Looks like it was introduced unintentionally when the code was rewritten here: 0eeefc5 and de81f6f

[smurawski]

#62 re-introduces the with_http_rescue since there is an http call in the mix - however, it checks the output object to see if it has a response code before dropping into the specific http response handling code. This should return the file object unimpeded and maintain the troubleshooting benefits of helpful http errors.