Fix a bug in freebsd-14.x due to changes in bsdinstall #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since FreeBSD 14.0, bsdinstall creates ZFS dataset for `home` rather than `/usr/home`, see freebsd/freebsd-src@3bb9230. This way, the previous workaround was broken, preventing the normal provisioning of the default Vagrant public keys. Signed-off-by: Anton Alekseev <anton@alekseev.cc>
|
devmuppet
added a commit
to devmuppet/bento_box
that referenced
this pull request
Oct 24, 2024
* Add FreeBSD 14.0-RELEASE (chef#1538) Signed-off-by: Li-Wen Hsu <lwhsu@lwhsu.org> * Fix os_arch of freebsd-13-aarch64 config (chef#1539) Signed-off-by: Li-Wen Hsu <lwhsu@lwhsu.org> * Bump almalinux minor versions (chef#1540) * - update to rockylinux 9.3 (chef#1542) * Bump Debian to v12.4, released December 10th, 2023 (chef#1541) * Update latest OS versions and fix arm64 build list command (chef#1543) * Update latest OS versions and fix arm64 build list command --------- * Fix upload public/private flag lookup (chef#1544) * fix upload public or private flag lookup * oracle 7 cleanup script error removing linux-firmware * ubuntu 23.10 post install command on file that doesn't exist * vagrant cloud cpu architecture support added (chef#1546) * vagrant cloud cpu architecture support added * fix metadata basename (chef#1548) fixed metadata base_boxname updated debian 11 to 11.9 updated debian 12 to 12.5 * Fix waiting for ssh - ubuntu netplan dhcp-identifer format error (chef#1550) * bumped iso url versions (chef#1553) * Update to FreeBSD 13.3 (chef#1556) * Update (chef#1559) Add amz Linux 2023 and update testing scripts * switch to ubuntu-latest runners (chef#1561) - Add back iso check, packer lint, and amazonlinux builds to build pipeline - Fix amazonlinux 2 build script - Added amazonlinux 2023 build scripts - Migrate Virtualbox and Qemu builds to github hosted runners from self-hosted runners - Added test-kitchen and kitchen-vagrant dependencies to gemspec - Added arg for bento test command to specify a specific build to test - this passes the arg to the kitchen test command - Fix vagrant post-processor to specify custom vagrant file for freebsd builds - Remove gui true from windows custom vagrant file - Fix test to skip removing linux-firmware on oraclelinux - Renamed oracle boxes to oraclelinux for consistency and remove edge cases in code - Removed unused -c flag for specifying a specific config file for bento build - Added --on-error flag to bento build command to pass to packer command - Added cpu architecture support to bento build command, so it'll only test builds that work with the current cpu architecture - Remove additional Ubuntu user-date last-command that may be locking macaddress - Add to test to move failed test boxes to builds/failed_testing directory - Changed ssh_timeout to 15m * fix typo in README (chef#1554) * fix typo in README * fix virtio-win.iso directory in README * fix mount of downloaded iso in qemu * Upgrade Windows 11 to 23H2 * add macos build (chef#1566) - Require ruby >= 3.0.0 - Add parallels-ipsw source - Added MacOS template for parallels-ipsw - Created MacOS scripts - Adjusted build flags to all be lower case for consistency - Removed extra amazonlinux directories to be more consistent with other builds - Added build_files directory for all temp files to be stored in during packer building - Opensuse-leap-15.5 updated to 15.6 - Remove Fedora 38 and add 40 builds - Remove Ubuntu 23.10 and add 24.04 builds * Fix qemu_format="raw" causing wrong format for qemu (chef#1568) * setup workflow for hosted runners (chef#1547) * setup workflow for hosted runners * bump AlmaLinux 8 version to 8.10 (chef#1569) * update OS versions (chef#1570) * update OS versions --------- Signed-off-by: Corey Hemminger <hemminger@hotmail.com> * 🐛 fix shell exec err (chef#1572) Signed-off-by: acejilam <acejilam@gmail.com> * Fix a bug in freebsd-14.x due to changes in bsdinstall (chef#1573) Since FreeBSD 14.0, bsdinstall creates ZFS dataset for `home` rather than `/usr/home`, see freebsd/freebsd-src@3bb9230. This way, the previous workaround was broken, preventing the normal provisioning of the default Vagrant public keys. Signed-off-by: Anton Alekseev <anton@alekseev.cc> Co-authored-by: Corey Hemminger <hemminger@hotmail.com> * Fix arm64 builds for debian 11 (chef#1571) * fix open-vm-tools installation in debian11 Signed-off-by: fgierlinger <2966031+fgierlinger@users.noreply.github.com> * prevent "unknown ioctl 1976" log spam Signed-off-by: fgierlinger <2966031+fgierlinger@users.noreply.github.com> --------- Signed-off-by: fgierlinger <2966031+fgierlinger@users.noreply.github.com> Co-authored-by: Corey Hemminger <hemminger@hotmail.com> * Update ubuntu-24.04 to latest ISO urls (24.04 to 24.04.1) (chef#1577) Signed-off-by: Phillip Ross <phillip.w.g.ross@gmail.com> * update hashicorp/qemu packer plugin to fix QEMU build, supporting efi_drop_efivars variable (chef#1580) * update Ubuntu Jammy releases (chef#1578) * update Ubuntu releases Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com> * 23.10 removed Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com> --------- Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com> Co-authored-by: Corey Hemminger <hemminger@hotmail.com> * Bump Debian from 12.5 to 12.7 (chef#1579) Signed-off-by: Seth Grover <seth.d.grover@gmail.com> * add Ubuntu 24.10 (Oracular Oriole) (chef#1583) Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com> --------- Signed-off-by: Li-Wen Hsu <lwhsu@lwhsu.org> Signed-off-by: Corey Hemminger <hemminger@hotmail.com> Signed-off-by: acejilam <acejilam@gmail.com> Signed-off-by: Anton Alekseev <anton@alekseev.cc> Signed-off-by: fgierlinger <2966031+fgierlinger@users.noreply.github.com> Signed-off-by: Phillip Ross <phillip.w.g.ross@gmail.com> Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com> Signed-off-by: Seth Grover <seth.d.grover@gmail.com> Co-authored-by: Li-Wen Hsu <lwhsu@lwhsu.org> Co-authored-by: Shawn Kelly O'Shea <shawn@eth0.net> Co-authored-by: Phillip Ross <phillipross@users.noreply.github.com> Co-authored-by: Seth Grover <13872653+mmguero@users.noreply.github.com> Co-authored-by: Corey Hemminger <hemminger@hotmail.com> Co-authored-by: Theo Dickinson <theodson@gmail.com> Co-authored-by: Jimmy Huang <jimmy.huang@duragility.com> Co-authored-by: Matthias Blümel <blaimi@blaimi.de> Co-authored-by: Daniel Widerin <daniel@widerin.net> Co-authored-by: ls-2018 <m202140037@xs.ustb.edu.cn> Co-authored-by: Anton Alekseev <anton@alekseev.cc> Co-authored-by: fgierlinger <2966031+fgierlinger@users.noreply.github.com> Co-authored-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initially the problem was like
Really, there was no
.sshinvagrants$HOMEIt turns out that since FreeBSD 14.0
bsdinstallreverted to it's former behaviourand creates ZFS dataset for
homerather than/usr/home1 2This PR fixes the issue, while preserving the former behaviour for the major versions of FreeBSD
< 14, namelyfreebsd-13.ximages.Types of changes
Checklist:
Gemfile.lockhas changed, I have used--conservativeto do it and included the full output in the Description above.Footnotes
https://github.com/freebsd/freebsd-src/commit/3bb92304b4fe79babd19ba0d9c74d29af9117a22 ↩
https://reviews.freebsd.org/D40086 ↩