-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add profile version to archive #1351
Conversation
354c19b
to
2ad78cd
Compare
Great improvement @jaxxstorm Can you rebase and fix the lint error? Happy to merge it then. |
@@ -399,9 +399,12 @@ def archive_name(opts) | |||
name = params[:name] || | |||
fail('Cannot create an archive without a profile name! Please '\ | |||
'specify the name in metadata or use --output to create the archive.') | |||
version = params[:version] || | |||
fail('Cannot create an archive with a profile version! Please '\ | |||
'specify the version in metadat or use --output to create the archive.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
metadata
2ad78cd
to
ad06068
Compare
@chris-rock I fixed the lint error, but we're still failing here. Any tips? |
@jaxxstorm We need to update our functional tests as well: You can quickly run the specific tests locally with: |
90dc1ae
to
ad06068
Compare
Signed-off-by: Lee Briggs <lbriggs@apptio.com>
512eb95
to
941c1ba
Compare
Signed-off-by: Lee Briggs <lbriggs@apptio.com>
941c1ba
to
0253031
Compare
Woot, finally got there, thanks @chris-rock ! |
@jaxxstorm Cool. Thank you for the quick turnaround! |
Fixes #1350
Probably needs some discussion here...