throw an error during inspec check if the version is not correct #1832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
added
in progress
Type: Enhancement
alexpop
reviewed
May 18, 2017
lib/inspec/metadata.rb
Outdated
|
|
||
| # if version is set, ensure it is correct | ||
| if !params[:version].nil? && !valid_version?(params[:version]) | ||
| errors.push("Version need to be in SemVer format in #{ref}") |
adamleff
suggested changes
May 18, 2017
| if !params[:version].nil? && !valid_version?(params[:version]) | ||
| errors.push("Version need to be in SemVer format in #{ref}") | ||
| end | ||
|
|
||
| %w{ title summary maintainer copyright }.each do |field| | ||
| next unless params[field.to_sym].nil? | ||
| warnings.push("Missing profile #{field} in #{ref}") |
There was a problem hiding this comment.
Since the inspec check output will provide the filename that generated the warning:
✖ /Users/aleff/profiles/test1/inspec.yml:0:0: Version need to be in SemVer format in inspec.yml
... I propose can just change this to "Version needs to be in SemVer format" to avoid the duplicate "inspec.yml" output
lib/inspec/metadata.rb
Outdated
| def valid_version?(value) | ||
| Semverse::Version.new(value) | ||
| true | ||
| rescue Semverse::InvalidVersionFormat => _ex |
There was a problem hiding this comment.
Since we're not using the exception object, we can remove the => _ex from here.
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
adamleff
force-pushed
the
chris-rock/version-error
branch
from
6b0e2b5 to
b0ab35d
Compare
adamleff
approved these changes
May 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that inspec check fails if a non-semver version is used in inspec.yml