Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic fields for aws_vpcs #2930

Merged
merged 4 commits into from
Apr 12, 2018
Merged

Basic fields for aws_vpcs #2930

merged 4 commits into from
Apr 12, 2018

Conversation

clintoncwolfe
Copy link
Contributor

Adds properties and filter criteria to aws_vpcs for three commonly needed attributes of a VPC:

Filter criteria:

  • vpc_id
  • dhcp_options_id
  • cidr_block

Properties (all arrays of strings)

  • vpc_ids
  • dhcp_options_ids
  • cidr_blocks

In addition, performs some code cleanup in the singular form, aws_vpc.

Fixes #2926

@clintoncwolfe
Update singular implementation to avoid use of inner object
4a10461 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
@clintoncwolfe
Update docs and tests for 3 new filters and properties on aws_vpcs
deaffc7 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
@clintoncwolfe
Implement new filters and properties; one failing test due to odd Fil…
b1a24e8 
…terTable behavior

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
@clintoncwolfe
changes to avoid bug 2929
45e17f0 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
@clintoncwolfe clintoncwolfe added Type: New Feature Adds new functionality Platform: AWS Amazon Web Services-related issues labels Apr 9, 2018
@clintoncwolfe clintoncwolfe requested a review from a team as a code owner April 9, 2018 18:57
jquick
jquick approved these changes Apr 12, 2018
View reviewed changes
Copy link
Contributor

@jquick jquick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @clintoncwolfe !

@jquick jquick merged commit 745ff32 into master Apr 12, 2018
@jquick jquick deleted the cw/aws-vpcs-basic-fields branch April 12, 2018 19:48
@clintoncwolfe clintoncwolfe mentioned this pull request Apr 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miah miah miah approved these changes

@jquick jquick jquick approved these changes

Assignees
No one assigned
Labels
Platform: AWS Amazon Web Services-related issues Type: New Feature Adds new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clintoncwolfe @miah @jquick @adamhjk