Fixes configuration for Azure integrationt tests #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rakefile
Outdated
| @@ -162,7 +162,9 @@ namespace :test do | |||
| sh("cd #{integration_dir}/build/ && terraform workspace new #{tf_workspace}") | |||
|
|
|||
| # Generate Azure crendentials | |||
| creds = Train.create('azure').connection.connect | |||
| connection = Train.create('azure').connection | |||
| connection.connect | |||
There was a problem hiding this comment.
That shouldn't be necessary? https://github.com/chef/train/blob/a931a4dccf8d01b0a99de28d5c17b2b484e6ce06/lib/train/transports/azure.rb#L50
There was a problem hiding this comment.
Ahh nice catch. I'll update.
There was a problem hiding this comment.
I updated and confirmed it works without the explicit connect.
Updates some calls in train so we can access the configuration options for some integration tests. Signed-off-by: David McCown <dmccown@chef.io>
dmccown
force-pushed
the
dwm/fix-az-integration-tests
branch
from
fa1dcb9
to
86e7d5d
Compare
jquick
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates some calls in train so we can access the configuration options
for some integration tests.
Signed-off-by: David McCown dmccown@chef.io