Rescue EPIPE on connect in ssh transport #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSH will raise an Errno::EPIPE if the remote server closes the connection unexpectedly. This can happen, for example, in cases where a user has an improperly configured ProxyCommand for that host in `~/.ssh/config`. Adding EPIPE to the set of exceptions to rescue ensures that we raise Train::Transports::SSHFailed which callers of train my already be rescuing.
chris-rock
force-pushed
the
ssd/rescue-epipe
branch
from
8696324
to
5fe5151
Compare
|
fixes inspec/inspec#840 |
|
Thanks @stevendanna for this great improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSH will raise an Errno::EPIPE if the remote server closes the
connection unexpectedly. This can happen, for example, in cases where a
user has an improperly configured ProxyCommand for that host in
~/.ssh/config.Adding EPIPE to the set of exceptions to rescue ensures that we raise
Train::Transports::SSHFailed which callers of train my already be
rescuing.