diff --git a/spanner/google/cloud/spanner_v1/database.py b/spanner/google/cloud/spanner_v1/database.py index a72e250119174..fe57e4e981cd3 100644 --- a/spanner/google/cloud/spanner_v1/database.py +++ b/spanner/google/cloud/spanner_v1/database.py @@ -18,6 +18,7 @@ import threading import google.auth.credentials +from google.api_core import exceptions from google.gax.errors import GaxError from google.gax.grpc import exc_to_code from google.cloud.spanner_v1.gapic.spanner_client import SpannerClient @@ -208,14 +209,7 @@ def create(self): options=options, ) except GaxError as exc: - if exc_to_code(exc.cause) == StatusCode.ALREADY_EXISTS: - raise Conflict(self.name) - elif exc_to_code(exc.cause) == StatusCode.NOT_FOUND: - raise NotFound('Instance not found: {name}'.format( - name=self._instance.name, - )) - raise - + raise exceptions.from_grpc_error(exc.cause) return future def exists(self): diff --git a/spanner/tests/system/test_system.py b/spanner/tests/system/test_system.py index c8dc5df70baee..6324a30c2ce5a 100644 --- a/spanner/tests/system/test_system.py +++ b/spanner/tests/system/test_system.py @@ -36,6 +36,7 @@ from google.cloud._helpers import UTC from google.cloud.exceptions import GrpcRendezvous +from google.cloud.exceptions import NotFound from google.cloud.spanner_v1._helpers import TimestampWithNanoseconds from google.cloud.spanner import Client from google.cloud.spanner import KeyRange @@ -282,6 +283,38 @@ def test_create_database(self): for database in Config.INSTANCE.list_databases()] self.assertIn(temp_db_id, database_ids) + def test_table_not_found(self): + temp_db_id = 'temp_db' + unique_resource_id('_') + + table_name1 = 'MyTable' + table_name2 = 'NotMyTable' + self.assertNotEqual(table_name1, table_name2) + + create_table = ( + 'CREATE TABLE {} (\n' + ' Id STRING(36) NOT NULL,\n' + ' Field1 STRING(36) NOT NULL\n' + ') PRIMARY KEY (Id)') + create_table = create_table.format(table_name1) + create_index = 'CREATE INDEX IDX ON {} (Field1)'.format(table_name2) + + temp_db = Config.INSTANCE.database( + temp_db_id, + ddl_statements=[ + create_table, + create_index, + ], + ) + try: + temp_db.create() + except NotFound as exc: + self.assertEqual(exc.args[0], + 'Table not found: {0}'.format(table_name2)) + except: + self.fail() + + + def test_update_database_ddl(self): pool = BurstyPool() temp_db_id = 'temp_db' + unique_resource_id('_') diff --git a/spanner/tests/unit/test_database.py b/spanner/tests/unit/test_database.py index 316ca307574ba..97c9fe3b0e85f 100644 --- a/spanner/tests/unit/test_database.py +++ b/spanner/tests/unit/test_database.py @@ -284,7 +284,7 @@ def test___ne__(self): self.assertNotEqual(database1, database2) def test_create_grpc_error(self): - from google.gax.errors import GaxError + from google.api_core.exceptions import GoogleAPICallError client = _Client() api = client.database_admin_api = _FauxDatabaseAdminAPI( @@ -293,7 +293,7 @@ def test_create_grpc_error(self): pool = _Pool() database = self._make_one(self.DATABASE_ID, instance, pool=pool) - with self.assertRaises(GaxError): + with self.assertRaises(GoogleAPICallError): database.create() (parent, create_statement, extra_statements,