From 22d7c15f91a32e401a5706e5d4c573869724caab Mon Sep 17 00:00:00 2001 From: cheniujh <41671101+cheniujh@users.noreply.github.com> Date: Fri, 24 May 2024 19:32:22 +0800 Subject: [PATCH] fix: fix data race around spop Dobinlog (#2674) * fix spop binlog data race * adjust format --------- Co-authored-by: cjh <1271435567@qq.com> --- include/pika_set.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/include/pika_set.h b/include/pika_set.h index 34e47d5edc..c4b8eb2031 100644 --- a/include/pika_set.h +++ b/include/pika_set.h @@ -66,8 +66,12 @@ class SPopCmd : public Cmd { public: SPopCmd(const std::string& name, int arity, uint32_t flag) : Cmd(name, arity, flag, static_cast(AclCategory::SET)) { - srem_cmd_ = std::make_shared(kCmdNameSRem, -3, kCmdFlagsWrite | kCmdFlagsSet); - } + srem_cmd_ = std::make_shared(kCmdNameSRem, -3, kCmdFlagsWrite | kCmdFlagsSet); + } + SPopCmd(const SPopCmd& other) + : Cmd(other), key_(other.key_), members_(other.members_), count_(other.count_), s_(other.s_) { + srem_cmd_ = std::make_shared(kCmdNameSRem, -3, kCmdFlagsWrite | kCmdFlagsSet); + } std::vector current_key() const override { std::vector res; res.push_back(key_);