Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router 1.6.3~1.6.4增量编译问题 #133

Closed
fisherblue opened this issue Jun 24, 2019 · 8 comments · Fixed by #134
Closed

router 1.6.3~1.6.4增量编译问题 #133

fisherblue opened this issue Jun 24, 2019 · 8 comments · Fixed by #134
Labels

Comments

@fisherblue
Copy link

AGP:3.4.1
JAVA8
Gradle: 5.4.1

更新1.6.3(1.6.4也同样有问题)后,增量编译会报duplicate class,开始认为是google AGP的问题,所以提了一笔issue给google:https://issuetracker.google.com/issues/135628755#comment6
根据google工程师的分析,问题出在Router处理增量编译的逻辑上。

这个问题在1.6.2上也会出现,不过出现的概率明显小于1.6.3之后的版本。
麻烦看下这问题哦

@chenqizheng
Copy link
Collaborator

我看Route Transform是isIncremental是false,请问下1.6.3出现概率,大概多少次会出现一次。

@fisherblue
Copy link
Author

修改一些关联比较多的class几乎必现。
只要修改了然后运行就会报错,然后必须rebuild然后重新运行才行

@chenqizheng
Copy link
Collaborator

的确有增量编译的问题,1.6.3~1.6.4增加了并发编译支持,导致问题更加的容易出现。

在dev分支提交了,增加了增量编译的支持。修改详情点击这里

PS:增删module、aar可能会有问题。没想好怎么去对应删除Scanner的Records。增删module、aar还是需要clean build才能正常。

@chenenyu
Copy link
Owner

@chenqizheng 可以先提到1.6分支上看看 1.7目前支持了androidx

@chenqizheng
Copy link
Collaborator

@chenenyu 好的,已经cherry-pick到了1.6。我试了增量编译十几次,没出现报错了。

@fisherblue
Copy link
Author

@chenenyu @chenqizheng 准备好了的话可以发个小版本让我测试一下

@chenenyu
Copy link
Owner

@fisherblue 1.6.5-beta1 试试

@fisherblue
Copy link
Author

fisherblue commented Jun 27, 2019

@chenenyu 测试过了,问题没有出现了

另外我们的工程也是使用了androidx,麻烦将这笔patch也合并到1.7上吧

@chenenyu chenenyu mentioned this issue Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants