Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add an option to exclude files #16

Merged
merged 6 commits into from
Oct 30, 2022
Merged

feat: add an option to exclude files #16

merged 6 commits into from
Oct 30, 2022

Conversation

taozhiyu
Copy link
Contributor

Exclude specified files, supports string, RegExp and function.

@taozhiyu
feat: add an option to exclude files
9820d43 
Exclude specified files, supports string, RegExp and function.
@taozhiyu
add example
a8f486b
@taozhiyu
Adding content callbacks
0bb9562 
Theoretically, if the callbacks of content is available, adding banners in front of all the files can be considered, rather than just matching js and css file.(users can process themselves)
@taozhiyu
fix jsdoc issue
33bc9d7
@taozhiyu
fix issues while adding content Callback support
7fabe04
chengpeiquan
chengpeiquan reviewed Oct 30, 2022
View reviewed changes
Copy link
Owner

@chengpeiquan chengpeiquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition to a new feature! I'm looking forward to it being merged, but before that I have a few small suggestions, please check out the comments.

src/types/index.ts Outdated Show resolved Hide resolved
src/types/index.ts Outdated Show resolved Hide resolved
src/types/index.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
chengpeiquan
chengpeiquan reviewed Oct 30, 2022
View reviewed changes
src/main.ts Outdated Show resolved Hide resolved
@taozhiyu taozhiyu requested a review from chengpeiquan October 30, 2022 12:49
@taozhiyu
Copy link
Contributor Author

It was an oversight on my part, I didn't take into account the reuse of functions.

I remove exclude replaced by content callback, which seems better, it looks like it's all done now.

chengpeiquan
chengpeiquan approved these changes Oct 30, 2022
View reviewed changes
Copy link
Owner

@chengpeiquan chengpeiquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@chengpeiquan chengpeiquan merged commit 9041f2c into chengpeiquan:main Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chengpeiquan chengpeiquan chengpeiquan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taozhiyu @chengpeiquan